Skip to content

Code Review ​

PRs are how we share knowledge and catch mistakes — not gatekeeping.

Author responsibilities ​

  • Keep PRs small. Aim for <400 lines changed. If it's bigger, split it or warn the reviewer.
  • Self-review first. Read your own diff before requesting review.
  • Write a description that answers: what changed, why, and what the reviewer should pay attention to. Use the pull request template.
  • You own getting it merged. The PR does not move itself — you do. That means: if no review after 1 business day, ping the reviewer in Slack. Once you've addressed a comment, mark the conversation resolved yourself — don't wait for the reviewer to close it. Keep the PR unblocked until it's merged.
  • Notify Reviewer Send message with URL of PR in group project and tagging 2 reviewer. If you does not have any response from reviewer, you must to tag again in thread slack.

Reviewer responsibilities ​

  • Respond within 1 business day. If you can't, say so and reassign.
  • Distinguish blocking comments from suggestions. Prefix non-blocking feedback with nit: or optional:.
  • Approve when you'd be comfortable shipping it, not when it's perfect.

Disagreements ​

  • If author and reviewer can't agree after a round of back-and-forth, move to a quick call. Slack threads on PRs are where time goes to die.
  • Loop in the lead if still stuck. Tech lead breaks ties.